Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Terms of service page #3122

Merged
merged 5 commits into from
Aug 14, 2024
Merged

feat: Terms of service page #3122

merged 5 commits into from
Aug 14, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 14, 2024

Implements #2609 to make terms for both upload and downloads referenced in one place. Content is shared from the components that display this information.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

Project coverage is 43.09%. Comparing base (b990ddb) to head (2b71fa2).
Report is 9 commits behind head on master.

Files Patch % Lines
...ackages/openneuro-components/src/footer/Footer.tsx 0.00% 8 Missing ⚠️
packages/openneuro-app/src/scripts/routes.tsx 0.00% 2 Missing ⚠️
...p/src/scripts/uploader/upload-disclaimer-input.tsx 0.00% 2 Missing ⚠️
packages/openneuro-server/src/handlers/sitemap.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
+ Coverage   42.68%   43.09%   +0.41%     
==========================================
  Files         593      596       +3     
  Lines       37780    37840      +60     
  Branches     1094     1095       +1     
==========================================
+ Hits        16125    16306     +181     
+ Misses      21447    21327     -120     
+ Partials      208      207       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 0f77429 into master Aug 14, 2024
10 of 11 checks passed
@nellh nellh deleted the 2609-terms-and-conditions branch August 14, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant