Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null email in admin user list #3132

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Handle null email in admin user list #3132

merged 4 commits into from
Aug 28, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 28, 2024

Refactors to TypeScript and functional components to make testing easier. Adds a test for filtering the user list with a couple example users, including one to throw the error from #3129.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 97.31183% with 5 lines in your changes missing coverage. Please review.

Project coverage is 43.99%. Comparing base (b33cd43) to head (8757d14).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...es/openneuro-app/src/scripts/pages/admin/users.tsx 97.83% 4 Missing ⚠️
...es/openneuro-app/src/scripts/pages/admin/admin.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3132      +/-   ##
==========================================
+ Coverage   43.08%   43.99%   +0.91%     
==========================================
  Files         596      596              
  Lines       37849    37832      -17     
  Branches     1095     1126      +31     
==========================================
+ Hits        16307    16645     +338     
+ Misses      21335    20983     -352     
+ Partials      207      204       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 147ae17 into master Aug 28, 2024
7 of 10 checks passed
@nellh nellh deleted the admin-user-page-fixes branch August 28, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant