Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Support for cloud speech & translation connectors #173

Open
Lekhanrao opened this issue Aug 6, 2024 · 25 comments · May be fixed by #187
Open

Issue: Support for cloud speech & translation connectors #173

Lekhanrao opened this issue Aug 6, 2024 · 25 comments · May be fixed by #187
Assignees
Labels
C4GT Coding Coding related C4GT Community Assignable to C4GT community developers enhancement New feature or request

Comments

@Lekhanrao
Copy link
Collaborator

Lekhanrao commented Aug 6, 2024

Ticket Contents

Develop connectors for AWS and GCP speech & translation connectors.

Goals

To provide support for the speech and translations of data for cloud providers such as GCP and AWS.

Expected Outcome

The stack should have capabilities to do speech and translation using GCP and AWS models by providing appropriate speech/translation keys in the environment.

Acceptance Criteria

  1. The users should be able to do speech_to_text, text_to_speech and translation using GCP and AWS credentials
  2. These two new classes for speech_processor and translator should be put into language/src/extension.py file as composite values along with the existing Dhruva and Azure instances.

Implementation Details

  1. Write connectors for speech & translation services in GCP and AWS by following the Azure speech & translation connector files.
  2. The translation code is present in language/src/translator.py. Create two new classes for GCP and AWS translator by extending the Translator base class.
  3. The speech processor code is present in language/src/speech_processor.py. Create two new classes for GCP and AWS speech processors by extending the SpeechProcessor base class and implement the base methods.

Mockups/Wireframes

Product Name

Jugalbandi

Organisation Name

OpenNyAI

Domain

Legal

Tech Skills Needed

Python

Mentor(s)

@Lekhanrao @KaranrajM

Complexity

Low

Category

Backend

@Lekhanrao Lekhanrao added the C4GT Community Assignable to C4GT community developers label Aug 6, 2024
Copy link

Hi!
Important Details - These following details are helpful for contributors to effectively identify and contribute to tickets.

  • Sub-Category - Please mention the sub-category if any for the ticket

Please update the ticket

@Lekhanrao Lekhanrao added enhancement New feature or request C4GT Coding Coding related labels Aug 6, 2024
@Lekhanrao
Copy link
Collaborator Author

@c4gt-community-support, What are the sub-category types and where do we update that in the Issue template?

@Ris-code
Copy link

Ris-code commented Aug 8, 2024

@Lekhanrao Could you please assign me this issue. I would like to solve this.

@Lekhanrao
Copy link
Collaborator Author

Assigned ticket to @Ris-code

@Ris-code
Copy link

Ris-code commented Aug 9, 2024

Assigned ticket to @Ris-code

Thank you for assigning me the task. I have already wrote the code but how to test it because I am not having the credentials. Will it work with my own keys ? or I need to make a PR for you to check.

@KaranrajM
Copy link
Contributor

Hi @Ris-code you can test with your own keys to test the individual translator and language services. Once you verify that it is working, you can raise a PR and we will test code with the whole application and comment if there are any issues.

@Lekhanrao
Copy link
Collaborator Author

@Ris-code Please let us know if you have any update on this.

@Ris-code
Copy link

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

@KaranrajM
Copy link
Contributor

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

Hi @Ris-code you need to have pinnacle (one of the business service providers of whatsapp) credentials to connect to whatsapp. But for testing speech and translator services, we can directly test these classes with GCP & AWS keys right? There wont be a need to run the whole chatbot in whatsapp and then test them. We can test them through whatsapp as well but we need pinnacle keys.

@Ris-code
Copy link

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

Hi @Ris-code you need to have pinnacle (one of the business service providers of whatsapp) credentials to connect to whatsapp. But for testing speech and translator services, we can directly test these classes with GCP & AWS keys right? There wont be a need to run the whole chatbot in whatsapp and then test them. We can test them through whatsapp as well but we need pinnacle keys.

Yes I can directly test the APIs. Thank you. Working on it.

@yashpal2104
Copy link

Can you assign this issue to me

@Ris-code
Copy link

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

Hi @Ris-code you need to have pinnacle (one of the business service providers of whatsapp) credentials to connect to whatsapp. But for testing speech and translator services, we can directly test these classes with GCP & AWS keys right? There wont be a need to run the whole chatbot in whatsapp and then test them. We can test them through whatsapp as well but we need pinnacle keys.

Yes I can directly test the APIs. Thank you. Working on it.

I have made a PR changing the translator.py, speech_processor.py, extension.py, .env-dev.template and .env.template files. Please review it . I have already tested all the apis for gcp and aws, it is working fine.

@Lekhanrao
Copy link
Collaborator Author

@yashpal2104, This issue is already being worked upon by Ris-code. Seems like it is almost done and waiting our Team lead's review. So I will get back to you after that review and if we still need help. Thankyou! Btw, there are other issues that you could pick up. I will encourage you to please review our open issues and pick the ones that's of interest to you.

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM, could you please check the updates made by Ris-code and the PR request as well.

@yashpal2104
Copy link

sure no problem I will get to other issues

@Ris-code Ris-code linked a pull request Sep 1, 2024 that will close this issue
@Lekhanrao Lekhanrao linked a pull request Sep 17, 2024 that will close this issue
@Lekhanrao
Copy link
Collaborator Author

@KaranrajM to review the PR and close by Friday 4th Oct.

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM is this done?

@CraftyEngineer
Copy link

@Lekhanrao Could you please assign me this issue, i would like to work on it!

@Mayank-tech69
Copy link

@Lekhanrao Hello, could u please assign me this issue? i would like to work on it!!

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

@OutstandingWork
Copy link

@Lekhanrao Is the issue still open for contribution? I would like to work on it, if possible?

@CraftyEngineer
Copy link

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

Sure!
I gave 3 proposals in the currently ongoing C4GT applications, all for OpenNyAI, please do give it a read and consider them, would love to work with OpenNyAI

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

@KaranrajM , wanted to check if you are able to complete this pending 10%?

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

Sure! I gave 3 proposals in the currently ongoing C4GT applications, all for OpenNyAI, please do give it a read and consider them, would love to work with OpenNyAI

@CraftyEngineer, sure will look into it.

@Lekhanrao
Copy link
Collaborator Author

@KaranrajM 10% of work was pending on this I guess. is this done now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C4GT Coding Coding related C4GT Community Assignable to C4GT community developers enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants