Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include/orbis/ header issues #237

Open
ghost opened this issue Mar 26, 2023 · 1 comment
Open

include/orbis/ header issues #237

ghost opened this issue Mar 26, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 26, 2023

Missing header in master

OpenOrbis-PS4-Toolchain/include/orbis/Font.h

Line 5 in c63c9e6

#include <orbis/_types/font.h>

Confusing includes: libusb.h is orbis/_types/libusb.h

OpenOrbis-PS4-Toolchain/include/orbis/Usbd.h

Line 5 in c63c9e6

#include <libusb.h>

Unnecessary line: inttypes.h already includes stdint.h

OpenOrbis-PS4-Toolchain/include/orbis/_types/save_data.h

Line 2 in 747bc55

#include <stdint.h>
)
@illusion0001
Copy link
Contributor

Also space vs tabs inconsistencies + no line ending for eof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@illusion0001