Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: script now creates src folder #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed: script now creates src folder #147

wants to merge 2 commits into from

Conversation

Asiern
Copy link

@Asiern Asiern commented Mar 15, 2021

The python script now creates the necessary folders for the build

The python script now creates the necessary folders for the build
@kiwidoggie
Copy link
Collaborator

Is it possible to make this more dynamic? I try to avoid hardcoded paths to keep everything easy to use. Like scan a folder recursively for *.proto find the relative path, create the output folder at that path. I do this currently in the makefile. That way we can add/remove .cpp files where ever we want and it will still compile. The protobuf script should be similar.

@kiwidoggie kiwidoggie added the enhancement New feature or request label Mar 17, 2021
@Asiern
Copy link
Author

Asiern commented Mar 17, 2021

I modified the code so that now before moving the files it checks if the folder exists and creates it if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants