Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: release: artifacts are in python/dist #84

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

Tristramg
Copy link
Contributor

The wheels wheren’t uploaded (https://github.com/osrd-project/liblrs/actions/runs/11342006817/job/31541481837) :

Warning: No files were found with the provided path: dist. No artifacts will be uploaded.

This failed just with a warning, not an error.

Later, https://github.com/osrd-project/liblrs/actions/runs/11342006817/job/31541648989 the wheels couldn’t be found resulting in an error

@emersion
Copy link
Member

We could add if-no-files-found: error to make CI fail when no files are uploaded.

@Tristramg
Copy link
Contributor Author

Thank you @emersion for this safeguard. I added it!

@emersion
Copy link
Member

I'm unsure whether the actions/download-artifact@v4 action will put files in the expected location. Maybe could test with a temporary dummy step which runs the download action and then runs tree?

Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
@Tristramg
Copy link
Contributor Author

@Tristramg Tristramg merged commit 217ac89 into main Oct 28, 2024
26 checks passed
@Tristramg Tristramg deleted the publish_pypi branch December 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants