Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph name should be unique with limit of 32 chars #185

Open
0xsarvesh opened this issue Oct 16, 2019 · 0 comments
Open

Subgraph name should be unique with limit of 32 chars #185

0xsarvesh opened this issue Oct 16, 2019 · 0 comments

Comments

@0xsarvesh
Copy link
Contributor

subgraph name has restriction of 32 chars after / character. Current implementation does substring of contract address to fit in size(Refer link). This logic doesn't guarantee the uniqueness in subgraph name.

https://github.com/mosaicdao/mosaic-chains/blob/cc36441350dac99c5225d8e0cf9db25b90bdbedf/src/Graph/SubGraph.ts#L178

One of the approach is to use a hashing function which takes 40bytes contract address as input and returns 16 bytes hash which could be used for subgraph name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant