Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting #64

Open
schemar opened this issue May 2, 2019 · 0 comments
Open

Fix linting #64

schemar opened this issue May 2, 2019 · 0 comments
Labels
opened:enhancement 💫

Comments

@schemar
Copy link
Contributor

schemar commented May 2, 2019 •
edited
Loading

After #62 was fixed and the linter was set up correctly, it revealed 83 issues.

  • Fix all issues.
  • Add linting to travis to enforce correct linting in the future.
@schemar schemar closed this as completed May 2, 2019
@schemar schemar reopened this May 2, 2019
schemar added a commit to schemar/mosaic-chains that referenced this issue May 2, 2019
@schemar
Set indent to 2 spaces
25d1172 
I updated the eslinter config to expect 2 spaces also for TypeScript
files.

I also ran the linter with the `--fix` option.

Now that the linter is set-up correctly, it returns 83 problems. I
created a follow-up ticket to fix the linting and add a linter check to
travis: OpenST#64

Fixes OpenST#62
@schemar schemar mentioned this issue May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
opened:enhancement 💫
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schemar