Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added command to deploy subgraph #178

Merged
merged 23 commits into from
Oct 17, 2019
Merged

Added command to deploy subgraph #178

merged 23 commits into from
Oct 17, 2019

Conversation

0xsarvesh
Copy link
Contributor

@0xsarvesh 0xsarvesh commented Oct 10, 2019 •
edited
Loading

fixes #176

This PR implements subgraph command to deploy subgraphs.

@0xsarvesh 0xsarvesh changed the title Added command to deploy subgraph Draft: Added command to deploy subgraph Oct 11, 2019
@0xsarvesh 0xsarvesh marked this pull request as ready for review October 11, 2019 14:52
@0xsarvesh 0xsarvesh changed the title Draft: Added command to deploy subgraph Added command to deploy subgraph Oct 15, 2019
@abhayks1 abhayks1 self-assigned this Oct 16, 2019
abhayks1
abhayks1 suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍
Please see inline comments below.

src/Config/GatewayAddresses.ts Outdated Show resolved Hide resolved
src/Config/GatewayAddresses.ts Show resolved Hide resolved
src/Config/GatewayAddresses.ts Show resolved Hide resolved
src/Config/GatewayAddresses.ts Outdated Show resolved Hide resolved
src/Config/GatewayAddresses.ts Outdated Show resolved Hide resolved
tests/smoke.sh Outdated Show resolved Hide resolved
tests/smoke.sh Outdated Show resolved Hide resolved
src/bin/mosaic-subgraph.ts Outdated Show resolved Hide resolved
src/bin/mosaic-subgraph.ts Show resolved Hide resolved
src/bin/mosaic-subgraph.ts Show resolved Hide resolved
@abhayks1 abhayks1 removed their assignment Oct 16, 2019
abhayks1
abhayks1 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
As discussed please add tests for mosaic-subgraph validations.
Also there are few linting issues which need to be fixed.

@abhayks1 abhayks1 merged commit 068361f into OpenST:develop Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhayks1 abhayks1 abhayks1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command to deploy subgraph for gateways
2 participants
@0xsarvesh @abhayks1