Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import rework Preview #2456

Open
1 task
MSoeb opened this issue May 30, 2024 · 7 comments
Open
1 task

Import rework Preview #2456

MSoeb opened this issue May 30, 2024 · 7 comments

Comments

@MSoeb
Copy link

MSoeb commented May 30, 2024

Description:
Given the new possibilities with participant-import:
It is worth discussing if the preview should only the data from the file, or whether it should show preexisting data.

Somethings which needs discussion:

  • how to handle data from the file which is new
  • how to handle data from the file which is old
  • how to handle the preview if the file is empty (at this place) but the data field is filled in the backend
  • how to handle the preview if the file is filled (at this place) but the data field is ALSO filled in the backend

What shoud be discussed/happen:

  • The preview should include all existing user data
@MSoeb MSoeb added bug staging Zeeman projectname Becquerel projectname Michelson projectname labels May 30, 2024
@MSoeb MSoeb added this to the 4.2 milestone May 30, 2024
@Elblinator Elblinator transferred this issue from OpenSlides/openslides-client May 30, 2024
@Elblinator
Copy link
Member

The second wanted behaviour (The preview should include all existing user data) is not implementable without a new concept.
So far this was actively not the desired behaviour, because the preview should only show data which was from the imported file.
After some internal discussions that part will become it's own Issue or clarifying actions will be updated here.

@luisa-beerboom
Copy link
Member

I extracted point 1 into its own issue #2457
I am changing the labels to this issue.

@luisa-beerboom
Copy link
Member

I also took out the project labels as I understood them to be applicable to the bug part of what was initially asked.
If that is wrong @Elblinator @MSoeb please add them back

@Elblinator Elblinator changed the title Membership number: user import by referencing data didn't work Import rework Preview May 31, 2024
@Elblinator
Copy link
Member

I'll move my comment to the bug Issue and deelte it in here

@luisa-beerboom
Copy link
Member

As far as showing pre-existing information goes: How about adding a new ImportState info for that? The client could show these cells as greyed out to visually differentiate them from what will actually be added as part of this import.
This would, of course mean that every field would now be an object field.

If both the backend and import file have data, I'd say what is written in the import file takes precedence and should be shown. As for the old data, we probably don't need to show it explicitly.

There is, of course, also the option of handling it completely differently by changing the return schema to something like tuple[bool<true when new data>, object|str|int|bool|etc] per field.

What do you think @r-peschke ?

@MSoeb
Copy link
Author

MSoeb commented Sep 23, 2024

I've added this Issue to the META issue OpenSlides/openslides-client#3809.

About you comment Luisa: A new participant concept is currently in developement. After we've added it in Github. We can and should discuss your notes after the integation in Github.

@luisa-beerboom
Copy link
Member

luisa-beerboom commented Nov 15, 2024

About you comment Luisa: A new participant concept is currently in developement. After we've added it in Github. We can and should discuss your notes after the integation in Github.

@MSoeb If I may ask: What relevance does a new participant concept have to this issue, which has, by now, become a more general import issue? Sure, there is a participant import as well, but there is also an account, topic, committee and motion import (even if the latter is, as of yet, unused in the client).

If we're going to be implementing this, we'd have to implement it for all of them anyway, for consistency's sake. So why wait just because the participant concept may change soon?
Is there a reason why we can't already start with the others right now?

Also:
Will the changes to the participant actually be so extremely impactful that we'll have to overhaul the entire participant import? Will there be a drastic reorganization of the import fields and how they are handled? Because otherwise this may still be worthwhile even for the participant import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants