Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish and incorporate cont state in utility functions #130

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Conversation

MaxBlesch
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (3799208) to head (3f8bd40).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...els/cons_ret_model_with_exp/state_space_objects.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   96.47%   95.74%   -0.73%     
==========================================
  Files          33       32       -1     
  Lines        1134     1128       -6     
==========================================
- Hits         1094     1080      -14     
- Misses         40       48       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxBlesch MaxBlesch requested a review from segsell October 3, 2024 15:17
Copy link
Member

@segsell segsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring, thank you!

@MaxBlesch MaxBlesch merged commit 2d17681 into main Oct 3, 2024
5 checks passed
@MaxBlesch MaxBlesch deleted the polish branch October 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants