Improve reviewer guidelines #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuellar
changed the title
MattiSG
changed the title
Cli4d
requested changes
Sep 1, 2023
There was a problem hiding this comment.
I like the changes you made @emmanuellar. I only feel there is one thing we can improve on. I have suggested the edit. You can have a look at it and commit the change if you are ok with it then I can merge the PR
Co-authored-by: Clifford Ouma <ochiengclifford2000@gmail.com>
Your changes look good to me, and I've accepted the commit. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for a partial rewrite of #63.