Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added Error state for Point mapper. #313

Closed
wants to merge 3 commits into from
Closed

Conversation

Geeker1
Copy link
Contributor

@Geeker1 Geeker1 commented Apr 14, 2021

Description

Added Error state with class .point-mapper-content__error which can be toggled from showPointError function in utils.js

Related Issue

#297

How to test it locally

Screenshots

Changelog

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for wazimap-staging ready!

Built with commit 0122011

https://deploy-preview-313--wazimap-staging.netlify.app

@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for wazimap-staging ready!

Built with commit 8192af4

https://deploy-preview-313--wazimap-staging.netlify.app

@Geeker1 Geeker1 marked this pull request as ready for review April 14, 2021 10:42
@paulmwatson paulmwatson closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants