-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data whitelisting #732
data whitelisting #732
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for wazimap-production ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
restrict_values
works across the app now :we skipped the my view : https://openupsa.slack.com/archives/C024AJAJ3T8/p1687203284338419
Related Issue
https://wazimap.atlassian.net/browse/WNCM-744
How is it tested automatically?
added test steps into
__tests__/gui/data_whitelist.feature
How should a reviewer test it locally
restrict_values
to profile configrestrict_values
are not displayed in anywhere elserestrict_values
, the indicator itself is not visibleScreenshots
Changelog
Added
Updated
src/js/api.js
to add wrapper functions. these functions call the functions that fetch the API data, then filter them out depending on the configRemoved
Checklist
Pull Request
Code Quality
Testing