Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data whitelisting #732

Merged
merged 14 commits into from
Jul 19, 2023
Merged

data whitelisting #732

merged 14 commits into from
Jul 19, 2023

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented Jun 19, 2023

Description

restrict_values works across the app now :

  • rich data panel
    • charts show only the whitelisted sub-indicators
    • filter dropdown options are whitelisted
  • data mapper
    • data mapper shows only the whitelisted sub-indicators
    • choropleth shows only the whitelisted sub-indicators
    • filter dropdown options are whitelisted

we skipped the my view : https://openupsa.slack.com/archives/C024AJAJ3T8/p1687203284338419

Related Issue

https://wazimap.atlassian.net/browse/WNCM-744

How is it tested automatically?

added test steps into __tests__/gui/data_whitelist.feature

How should a reviewer test it locally

  • add restrict_values to profile config
  • confirm that in the web page data mapper, rich data charts and filter dropdowns are filtered out to show just the restricted values
  • confirm that in the data mapper and the rich data panel, the sub-indicators that are not included in restrict_values are not displayed in anywhere else
  • confirm that in the data mapper and the rich data panel if none of the sub-indicators of an indicator exist in restrict_values, the indicator itself is not visible

Screenshots

image

Changelog

Added

Updated

  • src/js/api.js to add wrapper functions. these functions call the functions that fetch the API data, then filter them out depending on the config

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design match the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wazimap-ng-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:28am
wazimap-ng-ui-express ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 8:28am

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for wazimap-production ready!

Name Link
🔨 Latest commit f9915aa
🔍 Latest deploy log https://app.netlify.com/sites/wazimap-production/deploys/64b4fad47ebd5d00089c98c0
😎 Deploy Preview https://deploy-preview-732--wazimap-production.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@goyal1092 goyal1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goyal1092 goyal1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants