Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current view #735

Merged
merged 16 commits into from
Jul 24, 2023
Merged

current view #735

merged 16 commits into from
Jul 24, 2023

Conversation

emre2038
Copy link
Contributor

Description

A meaningful description of proposed change in your own words.

Related Issue

How is it tested automatically?

Is the particular functionality/structure of the backend API this relies on tested?
What unit, integration, GUI, end-to-end tests were added to test the functionality implemented/fixed in this PR?
What other tests does it rely on so that the new tests are sufficient?

How should a reviewer test it locally

Screenshots

Changelog

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design match the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wazimap-ng-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 2:33pm
wazimap-ng-ui-express ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 2:33pm

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for wazimap-production ready!

Name Link
🔨 Latest commit 46a89e5
🔍 Latest deploy log https://app.netlify.com/sites/wazimap-production/deploys/64be8b14e8f3d500089aff54
😎 Deploy Preview https://deploy-preview-735--wazimap-production.netlify.app/tabular-comparison
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emre2038 emre2038 marked this pull request as ready for review July 11, 2023 07:33
Copy link
Contributor

@goyal1092 goyal1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks Good 👍

Copy link
Contributor

@goyal1092 goyal1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants