Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiles): add ability to crop avatar #1089

Merged
merged 3 commits into from
Oct 14, 2024
Merged

feat(profiles): add ability to crop avatar #1089

merged 3 commits into from
Oct 14, 2024

Conversation

mrilyew
Copy link
Contributor

@mrilyew mrilyew commented Feb 4, 2024

Closes #1068 and maybe slash 106
image

@@ -1504,6 +1505,80 @@ $(document).on("click", "#add_image", (e) => {
cropper.rotate(-90)
})
})

$(".ovk-diag-body #_takeSelfie").on("click", (e) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без жквери

@@ -1504,6 +1505,80 @@ $(document).on("click", "#add_image", (e) => {
cropper.rotate(-90)
})
})

$(".ovk-diag-body #_takeSelfie").on("click", (e) => {
$("#avatarUpload")[0].style.display = "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно без жквери

@@ -334,8 +334,7 @@ function renderSub(): void
$this->redirect($user->getURL());
}

function renderSetAvatar()
{
function renderSetAvatar() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

что

@@ -18,9 +18,11 @@
{script "js/l10n.js"}
{script "js/openvk.cls.js"}
{script "js/node_modules/dashjs/dist/dash.all.min.js"}
<script src="/assets/packages/static/openvk/js/node_modules/cropperjs/dist/cropper.js" type="module"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

макросом надо

@celestora
Copy link
Member

ладно в принципе глобальных каких-то проблем не вижу, давайте заберём, а всё остальное пофиксим потом если надо будеь

Copy link
Member

@celestora celestora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@celestora celestora merged commit 2795e1e into master Oct 14, 2024
1 check passed
@celestora celestora deleted the crop-avatar branch October 14, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Баг після зміни аватарки профілю
2 participants