Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sing: more voice support #46

Open
JarbasAl opened this issue Aug 1, 2024 · 4 comments
Open

sing: more voice support #46

JarbasAl opened this issue Aug 1, 2024 · 4 comments

Comments

@JarbasAl
Copy link
Member

JarbasAl commented Aug 1, 2024

if using the SAM TTS, we could also have songs! having SAM in the first place already feels like a easter egg :)

@mikejgray
Copy link
Collaborator

mikejgray commented Nov 18, 2024

Checking for SAM usage is easy:

    def _sounds_like_sam(self) -> bool:
        tts = self.config_core.get("tts", {})
        if "sam" in tts.get("module", "").lower():
            return True
        return False

But playing YouTube videos is more complex...we'd have to do a lot of validation to see if we can use it through OCP/media. I don't see contact information for Noplan so no easy way to ask permission to get just the audio and provide an attribution link.

Thoughts on how to proceed, @JarbasAl ?

@JarbasAl
Copy link
Member Author

i'd just download the track and then bundle it with the skill, guess we should ask the author in this case, if it was a remote url we wouldnt need pemission but to bundle it we should reach out

@mikejgray
Copy link
Collaborator

I thought about that but there is no contact information for this channel that I could find...

@JarbasAl
Copy link
Member Author

I thought about that but there is no contact information for this channel that I could find...

if you cant ask for permission, ask for forgiveness 🤷‍♂️ leave a note on the readme with clear attribution and an offer to take it down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants