Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement CurrencySettler #21

Open
saucepoint opened this issue Nov 30, 2024 · 0 comments
Open

Reimplement CurrencySettler #21

saucepoint opened this issue Nov 30, 2024 · 0 comments

Comments

@saucepoint
Copy link
Collaborator

I see that some of the hooks (especially custom accounting) depend on CurrencySettler

I believe this was never audited in the original repos, as its not in v4-core/src/ -- thoughts on reimplementing our own here?

Also think we should move away from the boolean toggle for ERC20-vs-ERC6909 and just expose them separately (.settle / .burn and .take / .mint)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant