Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delay DLS transmission on overlap #13

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

cosimo-tribe
Copy link

Fix #12

@cosimo-tribe cosimo-tribe changed the title Don't delay DLS transmission on overlap Draft: Don't delay DLS transmission on overlap Sep 28, 2022
@cosimo-tribe
Copy link
Author

Setting it to Draft since I've noticed that with this change, despite immediately logging the ODR-PadEnc writing new DLS text "..." on a change, the receiver gets it some seconds after. So I guess there's something else that blocks; maybe it doesn't interrupt the slideshow sending immediately on a title update. I'll have a look at this, too.

@cosimo-tribe
Copy link
Author

cosimo-tribe commented Sep 28, 2022

Setting it to Draft since I've noticed that with this change, despite immediately logging the ODR-PadEnc writing new DLS text "..." on a change, the receiver gets it some seconds after. So I guess there's something else that blocks; maybe it doesn't interrupt the slideshow sending immediately on a title update. I'll have a look at this, too.

Ok, it was just the receiver I was using for this particular test, it expects the updated title two times, before displaying it. That explains why I didn't see this behaviour during my other tests.

@cosimo-tribe cosimo-tribe changed the title Draft: Don't delay DLS transmission on overlap Don't delay DLS transmission on overlap Sep 28, 2022
@basicmaster basicmaster changed the base branch from master to next September 28, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't delay DLS transmission on overlap
1 participant