refactor(api): Remove redundant tip length state #16450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbleon95
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PipetteStateandTipStatewere both storing the length of the pipette's currently-attached tip. I think that duplication was accidental. TheTipStateone was only used in one place, so this deletes that in favor of thePipetteStateone.Goes towards EXEC-758 by giving us one less thing to port.
Review requests
As far as I can tell, these did refer to exactly the same thing—the effective tip length (total length minus overlap). But double-check me.
Test plan
Because this is only affects the
VirtualGantryMover, used during protocol analysis, I think we can lean on analysis snapshot tests.Risk assessment
Low.