fix(protocol-designer): deck setup map not responsive #16768
Closed
+64
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
added
authorship
DO NOT MERGE
jerader
force-pushed
the
pd_testing-deck-responsiveness
branch
from
e08de3f
to
aec9955
Compare
jerader
requested review from
koji and
ncdiehl11
and removed request for
a team
|
closing because spoke with design and we want to go a different direction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3546
Overview
NOTE: do not merge until design reviews.
Refactor some of the deck map stuff to make deck setup responsive for smaller screens
Test Plan and Hands on Testing
Change the screen size from large to small (until you reach the screen to small overlay) in deck setup and check that the deck map and slot details is visible
Changelog
Risk assessment
low