feat(abr-testing): Record Liquid Heights found in ABR Protocols #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Nov 12, 2024
| ) | ||
| start_row_lhd = google_sheet_ldf.get_index_row() + 1 | ||
| google_sheet_ldf.batch_update_cells( | ||
| list_of_heights, "A", start_row_lhd, "1795535088" |
There was a problem hiding this comment.
It is the sheet id number. its the last string of of the google sheets url and I haven't figured out how to get it without a direct copy paste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Read liquid heights recorded in run log files and record on google sheet.
Test Plan and Hands on Testing
Ran script on protocols with and without liquid probing.
Changelog
Updated some protocols to include liquid height probing
Updated google sheets scripts to also batch record liquid heights found list
Review requests
Risk assessment