Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): incompatible tips modal copy update #16863

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 18, 2024

closes RQA-3318

Overview

Update copy in incompatible tips modal when uploading custom tips

Test Plan and Hands on Testing

Just check that the copy matches what is in the ticket. You can also try to upload a bad JSON file as well to the flow when adding custom tips in the onboarding flow to trigger the modal

Changelog

  • update copy
  • fix test

Risk assessment

low

@jerader jerader requested a review from a team as a code owner November 18, 2024 13:43
@jerader jerader removed the request for review from a team November 18, 2024 14:39
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jerader jerader merged commit a8c9c85 into edge Nov 18, 2024
24 checks passed
@jerader jerader deleted the pd_fix-incompatible-tips-copy branch November 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants