Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): remove liquid defining restrictions #16864

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 18, 2024

closes RQA-3260

Overview

Before, white, black and deprecated whale grey were restricted colors to add to PD. those restrictions are gone now and you can add whatever color you want

Test Plan and Hands on Testing

Test that black and white are selectable colors

Changelog

  • remove the liquid color restrictions to allow every color
  • delete unused util

Risk assessment

low

@jerader jerader requested a review from a team as a code owner November 18, 2024 14:00
@jerader jerader removed the request for review from a team November 18, 2024 14:01
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can select white and black and save.

@jerader jerader merged commit 8744089 into edge Nov 18, 2024
24 checks passed
@jerader jerader deleted the pd_remove-liquid-restrictions branch November 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants