Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute name 'openerp_connect' doesn't reflect what it represents at call time #3

Open
Nick-OpusVL opened this issue Aug 5, 2019 · 1 comment

Comments

@Nick-OpusVL
Copy link
Contributor

Nick-OpusVL commented Aug 5, 2019

https://github.com/OpusVL/OpenERP-OOM/blob/master/lib/OpenERP/OOM/Schema.pm

Should be openerp_connection_params or similar.

MooseX::Aliases would help us give it a new name with an alias to the old one, hopefully without breaking any existing code/configs.

Then $self->openerp_connect calls elsewhere in the OOM code can be replaced with ones that actually look like they're doing an attribute lookup rather than attempting to connect to an OpenERP.

This misunderstanding sent me on a wild goose chase.

@Nick-OpusVL Nick-OpusVL changed the title Attribute name 'openerp_connect' doesn't reflect what it represents Attribute name 'openerp_connect' doesn't reflect what it represents at call time Aug 5, 2019
@Nick-OpusVL
Copy link
Contributor Author

Nick-OpusVL commented Aug 5, 2019

A nice to have would be to show a deprecation warning if the original name is used in initialisation, set or looked up. MooseX::Deprecated might be able to help us with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant