You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MooseX::Aliases would help us give it a new name with an alias to the old one, hopefully without breaking any existing code/configs.
Then $self->openerp_connect calls elsewhere in the OOM code can be replaced with ones that actually look like they're doing an attribute lookup rather than attempting to connect to an OpenERP.
This misunderstanding sent me on a wild goose chase.
The text was updated successfully, but these errors were encountered:
Nick-OpusVL
changed the title
Attribute name 'openerp_connect' doesn't reflect what it represents
Attribute name 'openerp_connect' doesn't reflect what it represents at call time
Aug 5, 2019
A nice to have would be to show a deprecation warning if the original name is used in initialisation, set or looked up. MooseX::Deprecated might be able to help us with this.
https://github.com/OpusVL/OpenERP-OOM/blob/master/lib/OpenERP/OOM/Schema.pm
Should be
openerp_connection_params
or similar.MooseX::Aliases would help us give it a new name with an alias to the old one, hopefully without breaking any existing code/configs.
Then
$self->openerp_connect
calls elsewhere in the OOM code can be replaced with ones that actually look like they're doing an attribute lookup rather than attempting to connect to an OpenERP.This misunderstanding sent me on a wild goose chase.
The text was updated successfully, but these errors were encountered: