Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2 Governance #1991
base: master
Are you sure you want to change the base?
L2 Governance #1991
Changes from 7 commits
345c972
d35f4d1
5739d39
df4feca
dfc3c2f
385fa8b
c529d00
b37fa4e
f7cd591
6ab40c3
1fb49bb
1805822
e569b9a
ee37a06
81e0891
71a30ef
edf9614
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 7 in contracts/contracts/governance/L2Governor.sol
Codecov / codecov/patch
contracts/contracts/governance/L2Governor.sol#L7
Check warning on line 63 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L62-L63
Check warning on line 66 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L66
Check warning on line 71 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L71
Check warning on line 75 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L74-L75
Check warning on line 89 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L89
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary since you also have
queueL2Proposal
andcancelL2Proposal
and for nowL2Governance
only accepts these two message types?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you mean the
sendCommandToL2
and not this internal function? I can get rid of that, yeahThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, commented at the wrong place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed that
sendCommandToL2
. Also, removed theInvalidGovernanceCommand
check and error since those are not user-input nowCheck warning on line 100 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L100
Check warning on line 103 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L103
Check warning on line 107 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L107
Check warning on line 111 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L111
Check warning on line 118 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L118
Check warning on line 122 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L122
Check warning on line 129 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L129
Check warning on line 137 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L137
Check warning on line 140 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add a view function that returns the result of
getFee
to query before sending a command to make sure you have enough ETH in the contract for execution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added a
getCCIPFees
method that takes the same params as_sendCommandToL2
but returns the fee amountCheck warning on line 144 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L144
Check warning on line 149 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L149
Check warning on line 154 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L154
Check warning on line 170 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L170
Check warning on line 176 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L176
Check warning on line 191 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L191
Check warning on line 196 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L196
Check warning on line 211 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L211
Check warning on line 216 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L216
Check warning on line 233 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L233
Check warning on line 237 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L237
Check warning on line 240 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L240
Check warning on line 244 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L244
Check warning on line 248 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L248
Check warning on line 251 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L251
Check warning on line 256 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L256
Check warning on line 266 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L266
Check warning on line 269 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L269
Check warning on line 274 in contracts/contracts/governance/MainnetGovernanceExecutor.sol
Codecov / codecov/patch
contracts/contracts/governance/MainnetGovernanceExecutor.sol#L274