Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ Audit changes for OETH Withdrawal Queue #2168

Open
wants to merge 238 commits into
base: master
Choose a base branch
from

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    063d8b2 View commit details
    Browse the repository at this point in the history
  2. fix text

    sparrowDom committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6e8332b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    b933f22 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    0a43d14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d31fe30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    03c544c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    9aa0d73 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. add some comments

    sparrowDom committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e99f86c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52ba11e View commit details
    Browse the repository at this point in the history
  3. lint and prettier

    sparrowDom committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e656ecb View commit details
    Browse the repository at this point in the history
  4. undo file delete

    sparrowDom committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fe113a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    71ad71f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c448bb View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    5d5e9cb View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Native staking updates (#2023)

    * Update Natspec
    
    * Generated docs for native eth strategy
    
    * Prettier and linter
    Fixed spelling of ValidatorAccountant events
    Implemented depositSSV
    
    * Updated Natspec
    Moved MAX_STAKE on ValidatorAccountant to a constant
    
    * Removed strategist from strategy as its already maintained in the Vault
    
    * Fix compilation error
    
    * Fix unit tests
    
    * fix linter
    naddison36 authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    121c7f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Native staking changes (#2024)

    * Added OETH process diagram with functions calls for native staking
    
    * Native Staking Strategy now hold consensus rewards at ETH
    FeeAccumulator now holds execution rewards as ETH
    Removed WETH immutable from FeeAccumulator
    Converted custom errors back to require with string
    collect rewards now converts ETH to WETH at harvest
    checkBalance is now validators * 32 plus WETH balance from deposits
    Renamed beaconChainRewardsWETH to consensusRewards
    Fixed bug in stakeETH that was converting all WETH to ETH
    naddison36 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8a64dc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Native staking changes and unit tests (#2029)

    * Fixed native staking deployment since the strategist is got from the vault
    
    * Refactor of some Native Staking events
    Refactor of Native Staking unit tests
    
    * Renamed AccountingBeaconChainRewards to AccountingConsensusRewards
    Accounting updated to handle zero ETH from the beacon chain
    
    * fixed bug not accounting for previous consensus rewards
    Blow fuse if ETH balance < previous consensus rewards
    
    * Pause collectRewardTokens and doAccounting on accounting failure.
    
    Validated asset on deposit to Native Staking Strategy.
    
    Moved depositSSV from NativeStakingSSVStrategy to ValidatorRegistrator
    
    moved onlyStrategist modified and VAULT_ADDRESS immutable from ValidatorAccountant to ValidatorRegistrator
    
    manuallyFixAccounting changed to use whenPaused modifier
    
    made fuseIntervalEnd inclusive
    
    Natspec updates
    
    refactoring of native staking unit tests
    naddison36 authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8419fc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    87c5254 View commit details
    Browse the repository at this point in the history
  2. shorten error message

    sparrowDom committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1d66508 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. fix depositing bug

    sparrowDom committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    00ec878 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Holesky deploy (#2026)

    * add basic steps to deploy OETH to holesky
    
    * prettier
    
    * minor change
    
    * holesky deployment ifles
    holesky deployment files
    
    * add holesky deployment files
    
    * minor fix
    
    * minor fixes
    
    * make the fork tests run on Holesky
    
    * add some more tests
    
    * testing SSV staking on Holesky
    
    * refactor where deployment files are located
    
    * more progress on deployment
    
    * add deposit to validator deployment files
    
    * remove log
    
    * prettier
    
    * lint
    
    * move file
    
    * SSV cluster info (#2036)
    
    * add ability to fetch SSV cluster information
    
    * prettier
    sparrowDom authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ec4933b View commit details
    Browse the repository at this point in the history
  2. manuallyFixAccounting changes (#2034)

    * manuallyFixAccounting now uses delta values and only callable by the strategist
    manuallyFixAccounting calls doAccounting to check the fuse is still not blown
    Removed accountingGovernor
    
    * Added pauseOnFail param to internal _doAccounting
    Increased the allowed delta values of manuallyFixAccounting
    
    * ran prettier
    naddison36 authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6179cb1 View commit details
    Browse the repository at this point in the history
  3. fix fork tests

    sparrowDom committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    da6a7b5 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    fd17ec9 View commit details
    Browse the repository at this point in the history
  2. prettier

    sparrowDom committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8f7d3d5 View commit details
    Browse the repository at this point in the history
  3. fix unit test

    sparrowDom committed May 6, 2024
    Configuration menu
    Copy the full SHA
    967fe49 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. mainnet native staking fork tests (#2037)

    * manuallyFixAccounting now uses delta values and only callable by the strategist
    manuallyFixAccounting calls doAccounting to check the fuse is still not blown
    Removed accountingGovernor
    
    * Added pauseOnFail param to internal _doAccounting
    Increased the allowed delta values of manuallyFixAccounting
    
    * ran prettier
    
    * Added Defender Relayer for validator registrator
    Added ssv utils to get cluster data
    Added native staking fork tests
    
    * Removed now redundant IWETH9 import
    
    * moved more logic into native staking fixture
    
    * Removed unused imports
    
    * fix native staking unit tests
    
    * Fail accounting if activeDepositedValidators < fullyWithdrawnValidators
    Changed Harvester to transfer WETH to dripper
    Added more mainnet fork tests for native staking
    
    * Updated the OETH value flows
    
    * Added governable Hardhat tasks
    Created a resolveContract util
    
    * deconstruct params for Hardhat tasks
    
    * WIP Hardhat tasks for validator registration
    
    * Added depositSSV HH task
    
    * Updated OETH contract dependency diagram
    
    * Update to diagrams
    
    * mini fixes
    
    * fix bug and minor test improvement
    
    * update yarn fulie
    
    * unify the holesky and the mainnet fork tests
    
    * prettier
    
    * re-deploy holesky native staking strategy (#2046)
    
    * test updates
    
    * also re-deploy the harvester
    
    * upgrade harvester as well
    
    * fix test
    
    * fix upgrade script and correct the bug in deploy actions
    
    * Deployed new Native Staking strategy including the proxy
    
    * Added Hardhat tasks for generic strategy functions
    
    * remove nativeStakingSSVStrategyProxy from js addresses file
    
    ---------
    
    Co-authored-by: Domen Grabec <grabec@gmail.com>
    naddison36 and sparrowDom authored May 7, 2024
    Configuration menu
    Copy the full SHA
    1af324d View commit details
    Browse the repository at this point in the history
  2. fix unit tests

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ce2ec63 View commit details
    Browse the repository at this point in the history
  3. fix global hooks filter

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    fe12d23 View commit details
    Browse the repository at this point in the history
  4. add github workflow

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c61c9bb View commit details
    Browse the repository at this point in the history
  5. another workflow fix

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7e2e640 View commit details
    Browse the repository at this point in the history
  6. another workflow fix

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    af8ea03 View commit details
    Browse the repository at this point in the history
  7. fix holesky tests

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    32480dd View commit details
    Browse the repository at this point in the history
  8. remove the .only

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0fb09ea View commit details
    Browse the repository at this point in the history
  9. prettier

    sparrowDom committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c7175bb View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Sparrow dom/native staking defender action (#2051)

    * adding defender action task
    
    * fix unit tests setup
    
    * update the registrator address of the native staking contract
    
    * fix up the operate validators script so that it works for native staking on holesky
    
    * also add the gitignore
    
    * add ability to exit if staking contract is paused
    sparrowDom authored May 9, 2024
    Configuration menu
    Copy the full SHA
    69abd8f View commit details
    Browse the repository at this point in the history
  2. Fix fork tests (#2050)

    * Fixed resolveAsset
    
    * Fixed validator fork tests
    Added error func sigs to ISSVNetwork
    
    * Fixed harvester behaviour tests
    
    * Fix global hooks
    
    * Fix tooling
    
    ---------
    
    Co-authored-by: Shahul Hameed <10547529+shahthepro@users.noreply.github.com>
    naddison36 and shahthepro authored May 9, 2024
    Configuration menu
    Copy the full SHA
    2f7a9cd View commit details
    Browse the repository at this point in the history
  3. add payable to fee accumulator (#2053)

    * add payable to fee accumulator
    
    * remove zero initializers
    
    * some gas savings
    sparrowDom authored May 9, 2024
    Configuration menu
    Copy the full SHA
    0623a47 View commit details
    Browse the repository at this point in the history
  4. fix linter

    naddison36 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f268742 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Fix balancer fork test

    naddison36 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    20d29a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a93df2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b898801 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    25170aa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1ff728 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c09cd46 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9d83e97 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7eb135b View commit details
    Browse the repository at this point in the history
  9. gas optimisation

    sparrowDom committed May 10, 2024
    Configuration menu
    Copy the full SHA
    579a93c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4c864ca View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e7b96e9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8a53f3e View commit details
    Browse the repository at this point in the history
  13. Merge remote-tracking branch 'origin/sparrowDom/nativeStaking' into s…

    …parrowDom/nativeStaking
    naddison36 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    98a193a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    905abf9 View commit details
    Browse the repository at this point in the history
  15. adjust the comment

    sparrowDom committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fc48427 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. add rate limit to calling manually fix accounting (#2057)

    * add rate limit to calling manually fix accounting
    
    * fix comment
    sparrowDom authored May 13, 2024
    Configuration menu
    Copy the full SHA
    4b51655 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    657b064 View commit details
    Browse the repository at this point in the history
  3. Fix linter

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    769018a View commit details
    Browse the repository at this point in the history
  4. Remove approveAssets on Swapper contract in 095_ogn_buyback script as…

    … it has already been done
    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b98e9de View commit details
    Browse the repository at this point in the history
  5. Fix Holesky fork tests

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    622a3b4 View commit details
    Browse the repository at this point in the history
  6. Fix mainnet fork tests

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c25745d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4ca3136 View commit details
    Browse the repository at this point in the history
  8. fix some Slither errors

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    37c9d0a View commit details
    Browse the repository at this point in the history
  9. Fix Slither warnings

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    193af2f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6d5034a View commit details
    Browse the repository at this point in the history
  11. Fix CI

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    848d578 View commit details
    Browse the repository at this point in the history
  12. Fix CI

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    79d5058 View commit details
    Browse the repository at this point in the history
  13. Upgrade to node.js 20

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7b7ac39 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6b2be67 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5f2f8f6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6baed9b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9ce05e1 View commit details
    Browse the repository at this point in the history
  18. fix codecov upload

    naddison36 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8c052d8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3687fbe View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6df4f5f View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    614b11e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    21d5569 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    8be6f90 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    c8288b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63a11f7 View commit details
    Browse the repository at this point in the history
  3. Fix Slither

    naddison36 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    abe0e9c View commit details
    Browse the repository at this point in the history
  4. add a util contract that is able to recalculate a valid deposit data …

    …root with an invalid signature
    sparrowDom committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cfe6a81 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Slither fixes

    Added Natspec
    naddison36 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3a35b55 View commit details
    Browse the repository at this point in the history
  2. Fix linter

    naddison36 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    28ae453 View commit details
    Browse the repository at this point in the history
  3. Updated contract diagram

    naddison36 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ad492cc View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    4872259 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    c491131 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e8c15b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acad4b9 View commit details
    Browse the repository at this point in the history
  4. Fix event values (#2060)

    * add withdrawal events to the tests
    
    * add WETH accounting
    
    * add better documentation
    
    * add sending WETH to the Vault back to fix manual accounting function
    
    * actually wrap the ETH to WETH before sending it to the Vault when manually fixing accounting
    
    * add withdrawal event to manually fix accounting
    
    * fix bugs and add tests with WETH accounting
    
    * add test to verify correct deposits
    
    * Gas changes to Native Staking's depositAll
    
    ---------
    
    Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au>
    sparrowDom and naddison36 authored May 22, 2024
    Configuration menu
    Copy the full SHA
    638bf30 View commit details
    Browse the repository at this point in the history
  5. Deploy latest Native Staking Strategy to Holesky (#2073)

    * Deployed new NativeStakingSSVStrategy
    
    * Generated latest Native Staking Strategy diagrams
    naddison36 authored May 22, 2024
    Configuration menu
    Copy the full SHA
    b4e9c3f View commit details
    Browse the repository at this point in the history
  6. Deploy native staking Proxy via Relayer (#2066)

    * deploy native staking proxy and add auxiliary functions to transfer its governance
    
    * Shortened error message in InitializeGovernedUpgradeabilityProxy.initialize
    
    ---------
    
    Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au>
    sparrowDom and naddison36 authored May 22, 2024
    Configuration menu
    Copy the full SHA
    77d7b07 View commit details
    Browse the repository at this point in the history
  7. Setup basic defender action (#2072)

    * deploy native staking proxy and add auxiliary functions to transfer its governance
    
    * Setup basic defender action
    
    * update defender-sdk version
    
    * add defender client as an external export
    
    * configuration update
    
    ---------
    
    Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au>
    sparrowDom and naddison36 authored May 22, 2024
    Configuration menu
    Copy the full SHA
    4c25093 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    c4456b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1922b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5ebf29 View commit details
    Browse the repository at this point in the history
  4. prettier

    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0643034 View commit details
    Browse the repository at this point in the history
  5. Add getting WETH from Dripper on mints over rebaseThreshold

    claimWithdrawal collects from Dripper and adds any unallocated WETH to the withdrawal queue if not enough liquidity available
    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a50f2d2 View commit details
    Browse the repository at this point in the history
  6. Restricted OETH's depositToStrategy to only deposit WETH

    depositToStrategy only deposits WETH not allocated to the withdrawal queue
    swapCollateral restricted to only swap to WETH
    swapCollateral adds to withdrawal queue after swap
    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    82b4fd1 View commit details
    Browse the repository at this point in the history
  7. Fixed unit tests

    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    10b95df View commit details
    Browse the repository at this point in the history
  8. Suppress Slither

    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f27966b View commit details
    Browse the repository at this point in the history
  9. Changed ssv util getClusterInfo to use the SSV API instead of the ssv…

    …-scanner
    
    Moved duplicate getClusterInfo in tasks to utils
    naddison36 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    112dd37 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    f3e9d35 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e9e24f View commit details
    Browse the repository at this point in the history
  3. Changed ssv util getClusterInfo to use the SSV API instead of the ssv…

    …-scanner
    
    Moved duplicate getClusterInfo in tasks to utils
    naddison36 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8cf9a25 View commit details
    Browse the repository at this point in the history
  4. Prettier

    naddison36 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fc09bed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb3b7e6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e163cff View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cdb36ef View commit details
    Browse the repository at this point in the history
  8. Fixes to withdrawal queue

    WIP withdrawal queue unit tests
    naddison36 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9d302ec View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ef1c325 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    267d045 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    beb9170 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    10259ce View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    dd7632d View commit details
    Browse the repository at this point in the history
  14. Fixed bug in claimWithdrawals

    Added more withdrawal queue coverage
    naddison36 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    84d9a7f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    bb8577f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    e853081 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Stake funds with confirmations for front-running protection of Beacon…

    … Deposits (#2074)
    
    * contract changes and tests for gated protection against front running
    
    * Update off-chain validator registration process to also consider stake threshold
    
    * front run protection changes (#2076)
    
    * Added Holesky deploy script
    
    * Fixed OUSD metapool fork test
    
    * Generated latest NativeStakingSSVStrategy contract diagrams
    
    * Deployed new NativeStakingSSVStrategy to Holesky
    
    ---------
    
    Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au>
    sparrowDom and naddison36 authored May 28, 2024
    Configuration menu
    Copy the full SHA
    12bba64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5632653 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a0e9da View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    93b3cdf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    003fcdb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9295fe7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8748170 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Configuration menu
    Copy the full SHA
    270a3f6 View commit details
    Browse the repository at this point in the history
  2. OZ - Native Staking - M-01 All Addresses Are Registered Validators by…

    … Default (#2081)
    
    * Added default NON_REGISTERED to VALIDATOR_STATE
    
    * Added explicit check that a validator has not already been registered
    
    * Added new Holesky deploy script
    naddison36 authored Jun 2, 2024
    Configuration menu
    Copy the full SHA
    706da2e View commit details
    Browse the repository at this point in the history
  3. OZ - Native Staking - N-07 Lack of Indexed Event Parameters (#2083)

    * Indexed the RegistratorChanged and StakingMonitorChanged events
    
    * Added indexed pubKeyHash to validator events
    naddison36 authored Jun 2, 2024
    Configuration menu
    Copy the full SHA
    71adea7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8f8118d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d398042 View commit details
    Browse the repository at this point in the history
  6. P2P API changes (#2084)

    * Updated Natspec
    
    * Updated native staking process diagrams
    
    * Fixed signer for Holesky
    
    * split operateValidators into registerValidators and stakeValidators
    
    * Fix vault mint HH task. It now waits for the approve tx to be mined
    
    * resolveAsset to handle local Holesky fork
    
    * upgrade signer to use new defender-relay-client package
    
    * added approve option to vault mint HH task
    
    * Added stakeValidators HH task
    
    * update git ignore file
    
    * Added depositWETH and withdrawWETH HH tasks
    * Added resetStakeETHTally and setStakeETHThreshold HH tasks
    
    * generated latest Native Staking Strategy docs
    naddison36 authored Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b6c2219 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    81b9359 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Hardhat tasks for Native Staking (#2085)

    * Fixed depositSSV HH tasks
    
    * Added exitValidator and removeValidator HH tasks
    
    * Added doAccounting Defender Action
    
    * Added harvest HH task
    
    * Added fixAccounting and pauseStaking HH tasks
    
    * Fixed stakeValidators when run without uuid option
    naddison36 authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    49439ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e75f24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2081919 View commit details
    Browse the repository at this point in the history
  4. Cap the validators a Native Staking Strategy can hold (#2087)

    * Added max validators check to Native Staking Strategy
    naddison36 authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6ecf222 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    c807e8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ab4317 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f54c94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4f2a30 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Fix deployment file

    shahthepro committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2c90f9f View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    35c4848 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7849b81 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8b0fea View commit details
    Browse the repository at this point in the history
  4. Fixed unit tests

    naddison36 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a2dada1 View commit details
    Browse the repository at this point in the history
  5. Remove stETH from Vault in OETH Withdrawal Queue deployment is not al…

    …ready done
    
    Skip Lido Withdrawal Strategy tests
    naddison36 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    532e9b9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2075e66 View commit details
    Browse the repository at this point in the history
  7. Skipping OETH whale redeem in fork tests

    Added OETH whale request withdrawal to fork tests
    naddison36 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4ecffac View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f2c278b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8f46a2b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2f90d78 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bafeff1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    faf9521 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8094ddd View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    e811fc7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0cd7ac2 View commit details
    Browse the repository at this point in the history
  3. Added Vault requestWithdrawal andclaimWithdrawal Hardhat tasks

    Added Dripper collect and setDripDuration Hardhat tasks
    naddison36 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ba3c28c View commit details
    Browse the repository at this point in the history
  4. OETHVaultCore Natspec updates

    OETHVaultCore params with an underscore
    naddison36 committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    39d9a86 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    4e3a58d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    99f17e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add 30 minute time delay between request and claim from the OETH With…

    …drawal Queue. (#2127)
    
    * feat: add delay between request and claim.
    
    * test: update test with delay.
    
    * fix: move `CLAIM_DELAY` from `VaultStorage.sol` to `OETHVaultCore.sol`.
    
    * style: require error message start with capital letter.
    
    ---------
    
    Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au>
    clement-ux and naddison36 authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f8d4974 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b277f36 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    937a084 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ae24a1f View commit details
    Browse the repository at this point in the history
  5. Fixed unit tests

    naddison36 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b07ce57 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Remove stETH and rETH asset from OETH Vault

    Remove legacy strategies from the Vault
    naddison36 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    bdeb1de View commit details
    Browse the repository at this point in the history
  2. Skip legacy strategy tests

    naddison36 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    25f1b53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3049eff View commit details
    Browse the repository at this point in the history
  4. Skipped Aura price tests

    naddison36 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    3c9c9ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    14746bb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b7a6a10 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    dc58a1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5815778 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c607bc7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    33a5678 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cbd6764 View commit details
    Browse the repository at this point in the history
  6. Add solvency check. (#2131)

    * feat: add solvency check.
    
    * test: add test for solvency check.
    
    * docs: add comments
    
    * test: add more assertions.
    
    * style: run prettier
    
    * test: redeem with fees.
    
    * test: increase coverage.
    
    * test: increase coverage again.
    
    * fix: failing test.
    clement-ux authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f93f6ab View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    d3de400 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecc2773 View commit details
    Browse the repository at this point in the history
  3. Updated Natspec

    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    74875cd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5c2ab55 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cccc048 View commit details
    Browse the repository at this point in the history
  6. Fixed prettier

    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6ba210a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    52b2fe3 View commit details
    Browse the repository at this point in the history
  8. _checkBalance and _totalValue on OETH Vault to protect against insolv…

    …ency with most users requesting a withdrawal
    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f9e9fdd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e85f4fb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8c77769 View commit details
    Browse the repository at this point in the history
  11. Fix AMO fork tests

    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6eda2ed View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1ab9752 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    28e3ead View commit details
    Browse the repository at this point in the history
  14. Don't account for WETH reserved for withdrawal during allocation (#2138)

    * Override allocate method
    
    * Add test
    shahthepro authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e86fa11 View commit details
    Browse the repository at this point in the history
  15. WIP more unit tests

    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0f383e0 View commit details
    Browse the repository at this point in the history
  16. Added more unit tests

    naddison36 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e66dc12 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d67d1bf View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    61ead28 View commit details
    Browse the repository at this point in the history
  19. Fix skipped test

    shahthepro committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b0cd078 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Add extra test to OETH ARM. (#2139)

    * test: add extra fork test for claiming withdraw.
    
    * fix: div by zero on `_postRedeem()`.
    
    * test: add test when vault is insolvent.
    
    * test: when enough WETH in vault to cover exactly withdraw.
    
    * test: when more than enough WETH in vault to cover withdraw.
    clement-ux authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5ac4175 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b61c2b View commit details
    Browse the repository at this point in the history
  3. Refactor OETH Vault's _allocate() (#2141)

    * Refactor of OETH Vault's _allocate
    
    * Updated allocate test
    naddison36 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    975c3c6 View commit details
    Browse the repository at this point in the history
  4. Add extra test for OETH Withdraw Queue (#2142)

    * test: add tests for `_allocate()`.
    clement-ux authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5422808 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Override allocate on OETH Vault so _addWithdrawalQueueLiquidity is no…

    …t called twice on large mints (#2144)
    
    OEH Vault _allocate exits early if no default WETH strategy
    naddison36 authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    839bde2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d29d45 View commit details
    Browse the repository at this point in the history
  3. Fix unit tests

    shahthepro committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bb5a82a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    8bd687b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Add snapVault hardhat task

    naddison36 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9135275 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    cc6f2f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    133ddcb View commit details
    Browse the repository at this point in the history
  3. Fix _totalValue so it handles when vault value is less than the outst…

    …anding withdrawal requests
    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fb765e1 View commit details
    Browse the repository at this point in the history
  4. Added SafeCast to unit128

    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f3053f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22b8b2b View commit details
    Browse the repository at this point in the history
  6. Redeem to no longer try and get liquidity from the default strategy i…

    …f not enough available WETH in the vault
    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e59268f View commit details
    Browse the repository at this point in the history
  7. Simplify _wethAvailable

    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    74afa41 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dc46164 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4f5a57d View commit details
    Browse the repository at this point in the history
  10. Fix Slither

    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    193ad6d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f4de2e6 View commit details
    Browse the repository at this point in the history
  12. Set Vault buffer to 0.2%

    naddison36 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b9d5e00 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    acf271d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Simplify _totalValue logic

    naddison36 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5978d6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b26be9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    faa060a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d16970d View commit details
    Browse the repository at this point in the history
  5. Refactor _addWithdrawalQueueLiquidity

    Removed nonReentrant on addWithdrawalQueueLiquidity for now
    naddison36 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b6a2fbb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ad9592 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eca6ffa View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. M-01 _checkBalance Returns an Incorrect Value During Insolvency (#2166)

    * Fix checkBalance bug in new OETHVaultCore (#2162)
    
    * Added unit test for checkBalance when balance is less than the outstanding requests
    
    * Fix _checkBalance so it returns 0 when the amount of WETH in the vault and strategies is less than the outstanding withdrawal requests
    
    * Moved asset check to top of _checkBalance
    
    * simplified _totalValue by calling _checkBalance (#2163)
    naddison36 authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f9a2c80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f82a54d View commit details
    Browse the repository at this point in the history
  3. L-03 Missing Docstrings (#2169)

    * Added Natspec to VaultStorage
    
    * Added Natspec to VaultCore
    naddison36 authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b2d3e9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecd480f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c746ae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7bdbfd8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3b66f03 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    afb03d8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    edaf36e View commit details
    Browse the repository at this point in the history
  10. N-08 Variables Are Initialized to Their Default Values (#2176)

    * Removed unused MAX_UINT constant
    
    * Removed variables being initialized to their default values
    naddison36 authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3e6b68e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    49f15a5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c59070f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b9a2d81 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge remote-tracking branch 'origin/master' into nicka/oz-audit-fixe…

    …s-oeth-withdrawal-queue
    naddison36 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f69efcb View commit details
    Browse the repository at this point in the history