Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to another account #2245

Closed
wants to merge 21 commits into from
Closed

Conversation

sparrowDom
Copy link
Member

Rebase to another account

Copy link

github-actions bot commented Sep 19, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 5559819

Copy link

openzeppelin-code bot commented Sep 19, 2024

Rebase to another account

Generated at commit: 7d6201e727b9900c3e29cc1edb6171a395a99bd4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
18
43
67
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 18 lines in your changes missing coverage. Please review.

Project coverage is 18.13%. Comparing base (2674950) to head (5559819).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
contracts/contracts/token/OUSD.sol 70.96% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2245       +/-   ##
===========================================
- Coverage   53.40%   18.13%   -35.27%     
===========================================
  Files          79       79               
  Lines        4071     4158       +87     
  Branches     1070      835      -235     
===========================================
- Hits         2174      754     -1420     
- Misses       1894     3402     +1508     
+ Partials        3        2        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -849,4 +849,62 @@ describe("Token", function () {
await checkTransferOut(5);
await checkTransferOut(9);
});

it.only("Should delegate rebase to another account", async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .only needs to be removed

@sparrowDom
Copy link
Member Author

closing in favour of: #2298

@sparrowDom sparrowDom closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants