Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to rebasification #2286

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

naddison36
Copy link
Collaborator

No description provided.

Copy link

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against a57d371

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.60%. Comparing base (f9d3ea6) to head (a57d371).
Report is 1 commits behind head on sparrowDom/rebaseElsewhere.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           sparrowDom/rebaseElsewhere    #2286       +/-   ##
===============================================================
+ Coverage                       16.50%   53.60%   +37.09%     
===============================================================
  Files                              79       79               
  Lines                            4143     4125       -18     
  Branches                          831     1083      +252     
===============================================================
+ Hits                              684     2211     +1527     
+ Misses                           3457     1911     -1546     
- Partials                            2        3        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 marked this pull request as ready for review October 28, 2024 20:02
@sparrowDom
Copy link
Member

looks good thanks!

@sparrowDom sparrowDom merged commit 9665949 into sparrowDom/rebaseElsewhere Oct 28, 2024
13 of 18 checks passed
@sparrowDom sparrowDom deleted the nicka/rebaseElsewhere branch October 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants