Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OETHb] Direct Staking #2293

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[OETHb] Direct Staking #2293

wants to merge 15 commits into from

Conversation

shahthepro
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Oct 28, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 15ea15d

@shahthepro shahthepro marked this pull request as ready for review November 7, 2024 06:39
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 90 lines in your changes missing coverage. Please review.

Project coverage is 51.65%. Comparing base (20a21d0) to head (15ea15d).

Files with missing lines Patch % Lines
...tracts/crosschain/AbstractDirectStakingHandler.sol 5.55% 34 Missing ⚠️
...ts/contracts/crosschain/DirectStakingL2Handler.sol 13.15% 33 Missing ⚠️
...ntracts/crosschain/DirectStakingMainnetHandler.sol 33.33% 18 Missing ⚠️
...acts/contracts/strategies/BridgedWOETHStrategy.sol 82.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2293      +/-   ##
==========================================
- Coverage   52.19%   51.65%   -0.54%     
==========================================
  Files          79       82       +3     
  Lines        4098     4220     +122     
  Branches      824     1119     +295     
==========================================
+ Hits         2139     2180      +41     
- Misses       1956     2037      +81     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant