Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerodrome swap fees 20 deploy files #2294

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Oct 28, 2024

Contracts

Contract Address
AerodromeAMOStrategy (implementation) 0x8bb67820E8aC1a775DA25E50391718C1457d07ac

Governance

  • Update the AMO strategy implementation

Check attachments for generated JSON files
1730157451105-scheduleBatch-gov-tx.json
1730157451106-executeBatch-gov-tx.json

Important!
I had to deploy the contract twice, because the first time I accidentally deleted the schedule transaction files. The second deployed contract doesn't show constructor arguments on Base. But it exactly matches the code deployed on this address: 0xfc96Ab53Dd1864B26C0DbC8534154B32ad434335. You can use this one to verify the constructor arguments (the Basescan also notices that the deployed bytecode of the contracts match)

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@naddison36
Copy link
Collaborator

I've verified the deployment

  • All deployed contracts are listed in the deploy PR's description
    • AerodromeAMOStrategy
  • Deployed contract's verified code (and all dependencies) match the code in master
    • AerodromeAMOStrategy
  • The constructor parameters are correct
    • platformAddress, VaultAddress
    • weth address
    • OETHb address
    • swapRouter
    • nonfungiblePositionManager
    • clOETHbWethPool
    • gauge address
    • sugarHelper
    • lowerBoundingTick
    • upperBoundingTick
    • tickClosestToParity
  • The transactions that interacted with the newly deployed contract match the deploy script.
    • There are no txs outside the governance action
  • Governance proposal matches the deploy script
    • upgradeTo
  • Smoke tests pass after fork test execution of the governance proposal
sol2uml diff 0x8bb67820E8aC1a775DA25E50391718C1457d07ac .,node_modules -n base
Compared the "AerodromeAMOStrategy" contract with address 0x8bb67820E8aC1a775DA25E50391718C1457d07ac on base
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   @openzeppelin/contracts/utils/math/Math.sol
match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   @openzeppelin/contracts/utils/math/SafeMath.sol
match   contracts/governance/Governable.sol
match   contracts/interfaces/aerodrome/ICLGauge.sol
match   contracts/interfaces/aerodrome/ICLPool.sol
match   contracts/interfaces/aerodrome/INonfungiblePositionManager.sol
match   contracts/interfaces/aerodrome/ISugarHelper.sol
match   contracts/interfaces/aerodrome/ISwapRouter.sol
match   contracts/interfaces/IBasicToken.sol
match   contracts/interfaces/IStrategy.sol
match   contracts/interfaces/IVault.sol
match   contracts/strategies/aerodrome/AerodromeAMOStrategy.sol
match   contracts/token/OUSD.sol
match   contracts/utils/Helpers.sol
match   contracts/utils/Initializable.sol
match   contracts/utils/InitializableAbstractStrategy.sol
match   contracts/utils/InitializableERC20Detailed.sol
match   contracts/utils/StableMath.sol
match   contracts/vault/VaultStorage.sol

naddison36
naddison36 previously approved these changes Oct 29, 2024
shahthepro
shahthepro previously approved these changes Oct 29, 2024
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@shahthepro shahthepro dismissed stale reviews from naddison36 and themself via 05ca8a1 October 31, 2024 15:04
@shahthepro shahthepro merged commit 0565423 into master Oct 31, 2024
10 of 11 checks passed
@shahthepro shahthepro deleted the sparrowDom/deploy_020 branch October 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants