-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy 109 - 3rd native staking strategy #2309
Open
naddison36
wants to merge
3
commits into
master
Choose a base branch
from
nicka/deploy-109
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro and
clement-ux
as code owners
November 13, 2024 02:24
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
- Coverage 53.85% 53.12% -0.74%
==========================================
Files 79 79
Lines 4098 4098
Branches 1079 1079
==========================================
- Hits 2207 2177 -30
- Misses 1888 1918 +30
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Code Diff
|
shahthepro
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
|
sparrowDom
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment
Deploy script
109_3rd_native_ssv_staking.js
was developed in PR #2304Contracts
The
NativeStakingSSVStrategy3Proxy
contract was deployed by the Defender Relayer so the SSV rewards can be claimed.Governance
Proposal payload
Deploy checklist
Two reviewers complete the following checklist: