Skip to content

Commit

Permalink
Renamed methods for better readability
Browse files Browse the repository at this point in the history
  • Loading branch information
gnbm committed Sep 23, 2024
1 parent 5d50dfa commit 7558707
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions src/scripts/OutSystems/OSUI/Utils/Menu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,11 @@ namespace OutSystems.OSUI.Utils.Menu {

/**
* Method that add the OrientationChange handler, used only for TabletApps (Template_TabletApp > Menu)
* @deprecated
*
* @export
* @param {OSFramework.OSUI.GlobalCallbacks.Generic} callback
*/
export function AddMenuOnOrientationChange(callback: OSFramework.OSUI.GlobalCallbacks.Generic): void {
export function AddMenuOnOrientationChangeHandler(callback: OSFramework.OSUI.GlobalCallbacks.Generic): void {
if (callback !== undefined) {
_addMenuOnOrientationChange(callback);
}
Expand Down Expand Up @@ -491,10 +491,10 @@ namespace OutSystems.OSUI.Utils.Menu {

/**
* Method that removes the OrientationChange handler
* @deprecated
*
* @export
*/
export function RemoveMenuOnOrientationChange(): void {
export function RemoveMenuOnOrientationChangeHandler(): void {
_removeMenuOnOrientationChange();
}

Expand Down
12 changes: 6 additions & 6 deletions src/scripts/osui.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,22 @@ namespace osui {

namespace osui.utils.menu {
/**
* @deprecated use 'OutSystems.OSUI.Utils.Menu.OnReady(...)' instead.
* @deprecated use 'OutSystems.OSUI.Utils.Menu.AddMenuOnOrientationChangeHandler(...)' instead.
*/
export function AddMenuOnOrientationChanged(callback: OSFramework.OSUI.GlobalCallbacks.Generic): void {
console.warn(
'osui.utils.menu.AddMenuOnOrientationChanged(...), is deprecated. Please use the API `OutSystems.OSUI.Utils.Menu.OnReady(...)`.'
'osui.utils.menu.AddMenuOnOrientationChange(...), is deprecated. Please use the API `OutSystems.OSUI.Utils.Menu.AddMenuOnOrientationChangeHandler(...)`.'
);
return OutSystems.OSUI.Utils.Menu.AddMenuOnOrientationChange(callback);
return OutSystems.OSUI.Utils.Menu.AddMenuOnOrientationChangeHandler(callback);
}

/**
* @deprecated use 'OutSystems.OSUI.Utils.Menu.OnDestroy()' instead.
* @deprecated use 'OutSystems.OSUI.Utils.Menu.RemoveMenuOnOrientationChangeHandler()' instead.
*/
export function RemoveMenuOnOrientationChange(): void {
console.warn(
'osui.utils.menu.RemoveMenuOnOrientationChange(), is deprecated. Please use the API `OutSystems.OSUI.Utils.Menu.OnDestroy()`.'
'osui.utils.menu.RemoveMenuOnOrientationChangeHandler(), is deprecated. Please use the API `OutSystems.OSUI.Utils.Menu.RemoveMenuOnOrientationChangeHandler()`.'
);
return OutSystems.OSUI.Utils.Menu.RemoveMenuOnOrientationChange();
return OutSystems.OSUI.Utils.Menu.RemoveMenuOnOrientationChangeHandler();
}
}

0 comments on commit 7558707

Please sign in to comment.