Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11384: Adding new css variables to control progress animation speed #1003

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

rugoncalves
Copy link
Contributor

This PR is for adding new css variables to enable the developer to override the speed animation of the Progress Bar + Circle.

What was happening

  • When the speed of updating the value of the progress was higher than 5 per second, the progress was stuck in 0%, until the end, or until the update speed slowed down.

What was done

  • Added 2 new css variables that will enable the developer to override the animation speed value, making it fluid
    • --progress-initial-speed
    • --progress-speed

Example of usage

.override-speed .osui-progress-bar {
    --progress-initial-speed: 0.1s;
}

image

Screenshots

progress-bar-fix

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves requested a review from a team as a code owner November 28, 2024 14:17
Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rugoncalves rugoncalves merged commit ee060ac into dev Dec 2, 2024
14 checks passed
@rugoncalves rugoncalves deleted the ROU-11384 branch December 2, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants