Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom config path option #38

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

milindgoel15
Copy link
Contributor

Closes #37

  • Added path option to provide a custom location for package_rename_config.yaml file
  • Updated readme
  • Added basic help command that prints out command usages

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milindgoel15, thanks for the PR. I just need a few mentioned changes here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/package_rename.dart Outdated Show resolved Hide resolved
Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OutdatedGuy OutdatedGuy merged commit 3605341 into OutdatedGuy:main Aug 16, 2023
2 checks passed
@OutdatedGuy OutdatedGuy mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support config file location param
2 participants