Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: result channels with broadcast = False #326

Open
charlesbaynham opened this issue May 25, 2023 · 0 comments
Open

Question: result channels with broadcast = False #326

charlesbaynham opened this issue May 25, 2023 · 0 comments

Comments

@charlesbaynham
Copy link
Contributor

Looking through the code, it seems like ResultSinks can be created (or rather, build()ed) with broadcast=False. Am I right, however, that this option isn't currently exposed to the user?

If so, would a PR that added broadcast as an optional parameter for the __init__ of a ResultsChannel and then used that parameter when creating a sink for it in

if self.spec.axes:
sink = AppendingDatasetSink(
self, self.dataset_prefix + "points.channel_" + name)
else:
sink = ScalarDatasetSink(self, self.dataset_prefix + "point." + name)
channel.set_sink(sink)
self._scan_result_sinks[channel] = sink

sound like a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant