Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a Watir Element or Selenium Element as a parent element #137

Open
Castone22 opened this issue Nov 30, 2018 · 2 comments
Open

Using a Watir Element or Selenium Element as a parent element #137

Castone22 opened this issue Nov 30, 2018 · 2 comments

Comments

@Castone22
Copy link
Contributor

Currently it's possible to define direct driver elements in our page models like so

foo_section = browser.div(id: 'foo')
add_link(:foobar_link, parent: foo_section, id: 'foobar')

Doing so results in an error as currently we assume that the element being passed in as a parent will have #.watir_element defined on it (which watir and selenium elements do not). This is expected behavior and should likely be documented somewhere.

@PanoramicPanda
Copy link
Member

Is this need filled with #138 ?

@greenarrowdb
Copy link
Member

It would be better probably to enforce that a parent here is actually of type CoreElement. We don't want them to be creating watir elements directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants