Added Decision tree model #32 issue #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add the comments in cpp file soon till then, kindly check any other changes if required! |
|
Sir, this build error is not fixing, I don't know why, kindly look into it. |
|
@Sar-thak-3 pull fresh changes from main and remove the last line in cmake, it's possibly causing build failure |
|
Sir, checks were passed, kindly check is it okay? |
harshjohar
requested changes
Feb 17, 2023
I revert the changes but there is an issue in "src/slowmokit/ducks/matrix/matrix.cpp" , which is creating an error in build. |
CMakeLists.txt
Outdated
Comment on lines
29
to
48
| # base files | ||
| src/slowmokit/base.hpp | ||
| src/slowmokit/core.hpp | ||
| src/slowmokit/prereqs.hpp | ||
|
|
||
| # ducks | ||
| src/slowmokit/ducks/ducks.hpp | ||
| src/slowmokit/ducks/io/io.hpp | ||
| src/slowmokit/ducks/io/io.cpp | ||
| src/slowmokit/ducks/matrix/matrix.hpp | ||
|
|
||
| # methods | ||
| src/slowmokit/models/model.hpp | ||
| src/slowmokit/methods/neighbors/knn/knn.cpp | ||
| src/slowmokit/methods/neighbors/knn/knn.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression/linear_regression.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression/linear_regression.cpp |
There was a problem hiding this comment.
Remove all files added in cmake, and just keep the files till slowmokit.cpp
Sar-thak-3
force-pushed
the
decision_tree
branch
from
35860f2
to
eefc405
Compare
CMakeLists.txt
Outdated
Comment on lines
26
to
28
| add_library(slowmokit | ||
| src/slowmokit.hpp | ||
| src/slowmokit.cpp) |
There was a problem hiding this comment.
Vro all we need is this much, remove all the other files added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.