Feature/clean map on polygon #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazapatamar
requested changes
Jan 26, 2024
src/pages/search/Selector.jsx
Outdated
Comment on lines
57
to
61
| if (tabId === "draw-polygon") { | ||
| handlers.areaListChange(); | ||
| handlers.polygonChange(); | ||
| } else { | ||
| handlers.areaListChange(); |
There was a problem hiding this comment.
I don't like this approach.
-
you are calling the function ´areaListChange()´ when de condition is true and false, so in these cases you can simply put it out of the condition.
-
I like better try to inactivate all layers in Search instead of here. Check shutOffLayer funtion and try to use it inside polygonChange handler.
There was a problem hiding this comment.
reorganize the code because the "shutOffLayer " function is not executed when clicking the "Área de consulta" button
There was a problem hiding this comment.
What changes did you make in this file? I couldn't identify them
erikasv
requested changes
Feb 8, 2024
|
It was very difficult to review the changes because to a prettier update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.