Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further tests for preequilibration and reinitialization #30

Closed
dweindl opened this issue Oct 28, 2020 · 0 comments · Fixed by #35
Closed

Add further tests for preequilibration and reinitialization #30

dweindl opened this issue Oct 28, 2020 · 0 comments · Fixed by #35
Assignees

Comments

@dweindl
Copy link
Member

dweindl commented Oct 28, 2020

From PEtab doc:

If a species ID is provided, it is interpreted as the initial concentration/amount of that species and will override the initial concentration/amount given in the SBML model or given by a preequilibration condition. If NaN is provided for a condition, the result of the preequilibration (or initial concentration/amount from the SBML model, if no preequilibration is defined) is used.

This is insufficiently covered by the current tests. Case 10 is closest, but no NaNs for species entries in the condition table are present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants