Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py -> pyproject.toml #68

Merged
merged 3 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ci_pip_reqs.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pytest
flake8
https://github.com/petab-dev/libpetab-python/archive/develop.zip
sympy>=1.12.1
2 changes: 1 addition & 1 deletion .github/workflows/ci_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip wheel
pip install -r .ci_pip_reqs.txt
pip install -e .
pip install -r .ci_pip_reqs.txt
- name: Run tests
run: |
python -m flake8 \
Expand Down
2 changes: 2 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
include petabtests/conversion.xml
recursive-include petabtests/cases *
recursive-exclude **/__pycache__ *
exclude cases
38 changes: 38 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,41 @@
[build-system]
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = "petabtests"
dynamic = ["version"]
description = "PEtab testsuite library"
readme = "README.md"
authors = [
{ name = "Daniel Weindl", email = "sci@danielweindl.de" },
{ name = "Yannik Schaelte", email = "yannik.schaelte@gmail.com" },
]
maintainers = [
{ name = "Daniel Weindl", email = "sci@danielweindl.de" },
]
requires-python = ">=3.10"
classifiers = [
"Development Status :: 3 - Alpha",
"Intended Audience :: Developers",
"License :: OSI Approved :: BSD License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
keywords = ["PEtab", "testsuite"]
dependencies = [
"numpy>=1.22",
"pandas>=2.0",
"petab>=0.1.4",
"pysb>=1.16.0",
"simplesbml",
]

[project.urls]
homepage = "https://github.com/PEtab-dev/petab_test_suite"

[project.scripts]
petabtests_create = "petabtests.core:create"
petabtests_clear = "petabtests.core:clear"
32 changes: 0 additions & 32 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,41 +18,9 @@ def read(fname):
exec(read(path.join(here, 'petabtests', 'version.py')))

setup(
name='petabtests',
version=__version__, # noqa: F821
Copy link
Member

@dilpath dilpath Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can move this too I think

[tool.setuptools.dynamic]
version = {attr = "petabtests.__version__"}

Copy link
Member Author

@dweindl dweindl Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's possible, but this will require importing the package, which will require all module-level import dependencies to be installed in the temporary environment for building the sdist. Not sure it's worth it.
And it will require listing all those dependencies twice - for build + installation.

description='PEtab testsuite library',
long_description=long_description,
long_description_content_type='text/markdown',
url='https://github.com/PEtab-dev/petab_test_suite',
author='PEtab-dev',
author_email='yannik.schaelte@gmail.com',
maintainer='PEtab-dev',
maintainer_email='yannik.schaelte@gmail.com',
# author_email='',
classifiers=[
'Development Status :: 3 - Alpha',
'Intended Audience :: Developers',
'License :: OSI Approved :: BSD License',
'Operating System :: OS Independent',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
keywords='PEtab testsuite',
packages=find_namespace_packages(),
install_requires=[
'numpy',
'pandas',
'petab>=0.1.4',
'pysb',
'simplesbml',
],
python_requires='>=3.10',
entry_points={
'console_scripts': [
'petabtests_create = petabtests.core:create',
'petabtests_clear = petabtests.core:clear',
]
},
include_package_data=True,
)
Loading