Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ledger xpub #162

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Fix ledger xpub #162

merged 2 commits into from
Aug 27, 2023

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jul 28, 2023

No description provided.

@Liquid369 Liquid369 mentioned this pull request Jul 28, 2023
Closed
Liquid369
Liquid369 approved these changes Jul 28, 2023
View reviewed changes
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK f8d4697

This works each time, closed/reopened a few times, and pulls the correct xpub!

@JSKitty JSKitty requested a review from PalmTreeVI July 30, 2023 12:14
@JSKitty JSKitty added Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request labels Jul 30, 2023
@JSKitty
Copy link
Member

JSKitty commented Aug 27, 2023

Tested additionally by @PalmTreeVI, XPub fix seems good to go, merging.

@JSKitty JSKitty merged commit 52f8f51 into PIVX-Labs:master Aug 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liquid369 Liquid369 Liquid369 approved these changes

@sylvaincloutier sylvaincloutier sylvaincloutier approved these changes

@PalmTreeVI PalmTreeVI Awaiting requested review from PalmTreeVI

Assignees

@Duddino Duddino

Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
My PIVX Wallet v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Duddino @JSKitty @Liquid369 @sylvaincloutier