Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 🇵🇭 to the i18n system (by Clover) #164

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Aug 2, 2023

Abstract

This PR simply integrates Filipino Tagalog in to MPW, translated by community member Clover! 💜

image

@JSKitty JSKitty added the Enhancement New feature or request label Aug 2, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino and a team August 2, 2023 11:00
@JSKitty JSKitty self-assigned this Aug 2, 2023
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, not sure if we want to address these here or not but going to leave them here for the discussion.

Screenshot 2023-08-02 at 2 28 48 PM

Note: Addresses will always start as D
^^This is not tagged for i18n in the index.html template

Screenshot 2023-08-02 at 2 29 35 PM

This portion is not translated in the /tl/translation.js but it is in the PT/BR ones

Otherwise ACK, just clarify this and will approve if we consider it within scope right now!

@JSKitty
Copy link
Member Author

JSKitty commented Aug 2, 2023

Should all be finalised now! 🚀

On the above: these seem to be issues with the translation system itself (the Report is translated, but it will not update until you reload the app), the Vanity "addresses will always start with..." is also missing from the i18n system.

I'll resolve these in a future PR, likely after we finish UI updates, and round up translators to help fill in these missing bits afterwards, less messy this way if we handle i18n in bulk-portions. 🙏

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0b07672
Translations are being done by switching in various browsers, basic functions are still fine, LGTM

@JSKitty JSKitty merged commit 5932148 into master Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants