Add Balance Decimals slider setting #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
requested review from
Liquid369,
Duddino,
PalmTreeVI,
BreadJS and
a team
Liquid369
previously approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR adds a new Display customisation setting, "Balance Decimals", requested by a user, this setting allows the user to customise the decimals displayed by their wallet, and the wallet UI was adjusted to neatly include this feature without harming the UI flow.
You can set the decimals from 0 to 8 - 0 will completely disable them and round, while 8 will display down to the Satoshi level, the font size of the balance displays are adjusted to ensure they never overflow or look bad, as well as a new 'Number Beautifier' function which can adjust the Opacity and Font Size of decimal numbers for a lovely display.
0 Decimals:
2 Decimals (MPW Default Setting):
8 Decimals:
As you can see, the font size and opacity is adjusted on-the-fly, nice and tidy!
What does this PR address?
This PR resolves #155, a user requested feature to add Decimal Customisation to the wallet.