Add ability for MPW to run explorer-less #427
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Left some comments. Overall my idea is that we should make sure to have working explorers instead of making the code more ugly/complicated just to use RPC nodes as fallback.
For example: ok the explorers are not working and I can get the blockCount from the RPC node, but then getLatestTxs is going to fail anyways because it can only be done by an explorer, so what's the point?
| const newTx = await r.json(); | ||
| newTxs.push(newTx); | ||
| } else { | ||
| newTxs.push(tx); |
There was a problem hiding this comment.
this is very good, we should consider removing the explorer based getBlock
| await cNet.getLatestTxs(this); | ||
| fSynced = true; | ||
| } catch { | ||
| // If all Explorers are down, we'll just rely on the local TXDB and display a warning |
There was a problem hiding this comment.
I think this is more serious: getLatestTxs failed, wallet is almost unusable, balance is wrong and any attempt to create a tx will likely fail.
There was a problem hiding this comment.
Shield is fully usable and transactable, as well as Masternode controller and Governance. Meanwhile current MPW will not even open/load if explorers are down (which they are down far too frequently).
| return backend.bestBlockHash; | ||
| return backend.bestBlockHash; | ||
| } catch { | ||
| // Use Nodes as a fallback |
There was a problem hiding this comment.
I don't like using nodes as a fallback for light RPC calls like getBestBlockHash , sendTransaction and getBlockCount: the code is more ugly and imo we should just make sure to have working explorers
There was a problem hiding this comment.
Imo we would need at least 2x (4) explorers to consider it a stable network, or we start relying more on Nodes instead, it is the only compromise to get MPW more stable.
Abstract
This PR allows the majority of MPW data, aside from heavily indexed (Pubkey/XPub) data, to be acquired from Node RPCs.
This was initially as a fix for MPW being completely unloadable when Explorers are down, due to being unable to fetch chain data, MPW can't even pass the "Loading" screen - however after getting in to the rabbit hole, this PR is able to replace the reliance on Explorers almost entirely and allow full access to MPW despite total explorer outage, relying instead on the internal TXDB, internal mempool, and public RPC data.
This PR adds the ability to use all MPW functions aside from Transparent Sync - Shield can be fully utilised as normal.
RPC Layer Suggestions
This PR proposes the following RPCs be enabled on all RPC Servers supported by MPW:
getblockcount, getblockhash, getblock, getbestblockhash, getrawtransaction, sendrawtransactionIt would however be more efficient to develop a custom RPC layer API like
getblockbyheight, it would just begetblockhashpassed throughgetblock, halving the requests MPW needs to make for blockchain sync-via-RPC.TODOs
Shieldis synced and ready, butTransparentis not.Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!