feat: add additional pointer and type validations #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasel
commented
Oct 17, 2024
| @@ -1628,6 +1628,9 @@ impl Index { | |||
| if let DataTypeInformation::Pointer { inner_type_name, .. } = initial_type { | |||
| if let Some(ty) = self.find_effective_type_info(inner_type_name) { | |||
| return self.find_elementary_pointer_type(self.find_intrinsic_type(ty)); | |||
| } else { | |||
| // the inner type can't be found, return VOID as placeholder | |||
There was a problem hiding this comment.
This fixes a stack-overflow in typesystem::is_same_type_class when dealing with pointers of undefined type
mhasel
force-pushed
the
fix-pointer-validation-stack-overflow
branch
from
a13293b
to
d8ce876
Compare
mhasel
force-pushed
the
fix-pointer-validation-stack-overflow
branch
from
d8ce876
to
7a1d890
Compare
volsa
approved these changes
Oct 18, 2024
| @@ -746,6 +746,7 @@ fn parse_pointer_definition( | |||
| ( | |||
| DataTypeDeclaration::DataTypeDefinition { | |||
| data_type: DataType::PointerType { name, referenced_type: Box::new(decl), auto_deref }, | |||
| // FIXME: this currently includes the initializer in the sourcelocation, resulting in 'REF_TO A := B' when creating a slice | |||
There was a problem hiding this comment.
Should we track this on GitHub instead in the code itself? I feel like these FIXMEs are easily forgotten
There was a problem hiding this comment.
You're right, I've already set up a draft for this issue - just need to add a reproducible example.
Comment on lines
+771
to
+772
| 4 │ a: myDeclaredType; | ||
| │ ^^^^^^^^^^^^^^ Unknown type: myDeclaredType |
There was a problem hiding this comment.
We already talked about this yesterday offline, but the UX isn't good here; maybe we should also track this in a issue seperately and see if there's a solution to this (minor however)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some additional type validations for pointer variables being initialized with
ADR/REF.Also adds a validation to catch undeclared types, previously only reported during codegen.