Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate IDs for VEP annotation inout VCFs #107

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Marcel-Mueck
Copy link
Collaborator

What

When VCF files are normalized, sometimes there are multiple IDs for each variant concatenated with a semicolon(;) THis however leads to problems with the #Uploaded_variation column in VEP. This PR regenerates the IDs and makes sure each variant gets a unique ID.
Related to Issue #76, specifically this comment #76 (comment)

Testing

Tested locally on example data

Test scenarios

Run pipeline locally

@endast endast self-requested a review June 6, 2024 14:55
Copy link
Collaborator

@endast endast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Marcel-Mueck Marcel-Mueck merged commit 3b6a3e6 into main Jun 10, 2024
24 checks passed
@Marcel-Mueck Marcel-Mueck deleted the Regenerate-IDs-for-VEP-input branch June 10, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants