Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug seed gene pipeline crash #108

Merged
merged 13 commits into from
Jun 10, 2024
Merged

Bug seed gene pipeline crash #108

merged 13 commits into from
Jun 10, 2024

Conversation

endast
Copy link
Collaborator

@endast endast commented Jun 7, 2024

What

Fixes a problem in the seed gene discovery pipeline where a crash could occur if you had sample names that could not be cast to integers. #76 (comment)

To fix this we removed the unused --sample-file flag from the run-association cmd.

We also updated the seed genes config by adding a sample config for subsetting the samples and removed the batch_size from the example config (and also added a check to verify that you are not trying to pass the batch size via the config).

Also the test phenotypes data have been updated to include a non numeric sample name.

Testing

Running on the example data should be enough to test that it runs through.

You can add a batch size to the data_loader config to verify that the check works.
Skärmavbild 2024-06-07 kl  14 18 55

@endast endast requested a review from HolEv June 7, 2024 12:41
Copy link
Collaborator

@HolEv HolEv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HolEv HolEv merged commit 634a72c into main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants