Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving an unfilled copy of the annotations #153

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

Marcel-Mueck
Copy link
Collaborator

with these changes, a copy of the annotations.parquet file is saved containing NA values before filling these

What

This change will add the option --keep_unfilled to the select_rename_fill_annotations function in deeprvat_annotaions , which saves a copy of the annotations data frame before filling in any NA values to the data frame.

Testing

  • the test pipeline was successfully run with the changes,
  • test cases with the unfilled option were created to run automatically

Test scenarios

  • select_rename_fill function with --keep-unfilled option (test case exists, run automatically on example data)
  • select_rename_fill function without --keep-unfilled option (test case exists, run automatically on example data)
  • updated pipline which uses the --keep-unfilled option (tested locally on example data)

Copy link
Collaborator

@meyerkm meyerkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meyerkm meyerkm merged commit a85ee57 into main Dec 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants