Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature binary traits #27

Merged
merged 20 commits into from
Oct 13, 2023
Merged

Feature binary traits #27

merged 20 commits into from
Oct 13, 2023

Conversation

HolEv
Copy link
Collaborator

@HolEv HolEv commented Oct 10, 2023

dense_gt.py:

  • don't transform phenotypes if there are only two distinct values (i.e., it's a binary phenotype because association testing functions cannot handle the transformed values).

deeprvat/associate.py:

  • run ScoretestNoK on quantitative traits (!= 2 distinct y values) and ScoretestLogit on binary traits (2 distinct y values).
  • Account for the fact that ScoretestLogit doesn't return betas

seed_gene_discovery/seed_gene_discovery.py:

  • run ScoretestNoK on quantitative traits (!= 2 distinct y values) and ScoretestLogit on binary traits (2 distinct y values).
  • Account for the fact that ScoretestLogit doesn't return betas
  • fix in recording of timing
  • fix in dropping of duplicates of exploded annotations data frame (reset index (variant id) before dropping duplicates)
  • implement and use collapsing of ultra rare variants in SKAT tests

seed_gene_discovery/seed_gene_discovery.snakefile:

  • distinct roules for regression of missense/plof tests to optimise resource usage

@HolEv HolEv requested review from endast and bfclarke October 10, 2023 14:45
deeprvat/data/dense_gt.py Outdated Show resolved Hide resolved
deeprvat/deeprvat/associate.py Outdated Show resolved Hide resolved
deeprvat/deeprvat/associate.py Outdated Show resolved Hide resolved
deeprvat/data/dense_gt.py Outdated Show resolved Hide resolved
@HolEv HolEv removed the request for review from endast October 12, 2023 11:46
@bfclarke bfclarke merged commit 955f535 into main Oct 13, 2023
@endast endast deleted the feature-binary-traits branch April 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants